Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog #493

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Update changelog #493

merged 2 commits into from
Nov 6, 2024

Conversation

verseve
Copy link
Contributor

@verseve verseve commented Nov 6, 2024

No description provided.

vers-w added 2 commits November 6, 2024 08:27
@vers-w
Update changelog
ba7a6ea 
As internal variable names with non-ASCII characters have been replaced by ASCII equivalents, the TOML keys `kv₀`, `θᵣ` and `θₛ` are not supported anymore. This has been added to changelog.
@vers-w
Remove double quotes TOML keys in docs
c9bee20
@verseve verseve self-assigned this Nov 6, 2024
@verseve verseve marked this pull request as ready for review November 6, 2024 07:37
hboisgon
hboisgon approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if a deprecated section would not make it even clearer to users instead of list in this list but I do not know if it follows semantic versioning conventions

@verseve verseve merged commit 2a63e95 into master Nov 6, 2024
10 checks passed
@verseve verseve deleted the changelog_toml_ascii branch November 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboisgon hboisgon hboisgon approved these changes

@JoostBuitink JoostBuitink Awaiting requested review from JoostBuitink

Assignees

@verseve verseve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@verseve @hboisgon @vers-w